[PATCH] D107470: 2/3: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor
Igor Kudrin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 11 08:22:55 PDT 2021
ikudrin added inline comments.
================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFListTableTest.cpp:128
+ EXPECT_EQ(Table.getAddrSize(), 8U);
+ Extractor.setAddressSize(Table.getAddrSize());
+ Expected<DWARFDebugRnglist> List = Table.findList(Extractor, Offset);
----------------
This looks odd. `DWARFListTableBase::findList()` should not require the setting to be done in the calling code if it can apply it itself.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107470/new/
https://reviews.llvm.org/D107470
More information about the llvm-commits
mailing list