[PATCH] D107409: [Attributor] Propagate Cold attribute inter procedurally

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:4636
+};
+
 raw_ostream &operator<<(raw_ostream &, const AAPointerInfo::Access &);
----------------
We need more than a boolean state, no? Maybe we should use a 3-bit (or 4-bit) state here instead of an optional in the Impl.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:9605
+
+  void trackStatistics() const override {}
+
----------------
let's implement this one


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107409/new/

https://reviews.llvm.org/D107409