[PATCH] D107838: [CSSPGO] Do not use getCanonicalFnName in pseudo probe descriptor decoding

[Wenlei He via Phabricator via llvm-commits]

wenlei accepted this revision.
wenlei added a comment.

lgtm, thanks.



================
Comment at: llvm/lib/MC/MCPseudoProbe.cpp:360
-    StringRef Name =
-        FunctionSamples::getCanonicalFnName(std::move(*ErrorOrName));
 
----------------
hoy wrote:
> wenlei wrote:
> > does this have `__uniq.`? Can we assert it does not contain `.`?
> It can have that since the uniq suffx is from the frontend. We can assert it doesn't have `.llvm` etc...
ok, as long as it's verified to be no-op now, the risk of something breaking this is low. I think it's fine to leave it as is too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107838/new/

https://reviews.llvm.org/D107838