[PATCH] D107838: [CSSPGO] Do not use getCanonicalFnName in pseudo probe descriptor decoding
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 10 16:34:23 PDT 2021
hoy added inline comments.
================
Comment at: llvm/lib/MC/MCPseudoProbe.cpp:360
- StringRef Name =
- FunctionSamples::getCanonicalFnName(std::move(*ErrorOrName));
----------------
wenlei wrote:
> does this have `__uniq.`? Can we assert it does not contain `.`?
It can have that since the uniq suffx is from the frontend. We can assert it doesn't have `.llvm` etc...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107838/new/
https://reviews.llvm.org/D107838
More information about the llvm-commits
mailing list