[PATCH] D107657: [RISCV][VP] Add support for VP_REDUCE_* operations
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 10 08:44:56 PDT 2021
craig.topper added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2115
+SDValue DAGTypeLegalizer::PromoteIntOp_VP_REDUCE(SDNode *N, unsigned OpNo) {
+ SDLoc DL(N);
+ SDValue Op = PromoteIntOpVectorReduction(N, N->getOperand(OpNo));
----------------
What values of OpNo do we expect here? 0 shouldn't happen since it was handled in result promotion. 1 clearly will happen. I'm not sure about 2 and 3, but using PromoteIntOpVectorReduction for them would be incorrect.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107657/new/
https://reviews.llvm.org/D107657
More information about the llvm-commits
mailing list