[PATCH] D106408: Allow rematerialization of virtual reg uses

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 6 16:18:52 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetInstrInfo.h:123-125
+  /// in the function. If \p AllowVRegs is set to true then virtual register
+  /// uses are allowed as well for regalloc to opportunistically rematerialize
+  /// an instruction if all used registers happen to be available.
----------------
arsenm wrote:
> I don't understand why AllowVRegs needs to be a parameter. Why wouldn't it just always true?
i.e. this is rematerializable, the pressure question is a different heuristic


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106408/new/

https://reviews.llvm.org/D106408



More information about the llvm-commits mailing list