[PATCH] D107707: [MC][ELF] Do not error on parsing .debug_* section directive for MIPS

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 8 12:25:18 PDT 2021


atanasyan added inline comments.


================
Comment at: llvm/lib/MC/MCParser/ELFAsmParser.cpp:518
+    // but in assembly files these sections have SHT_PROGBITS type.
+    return Section->getType() == ELF::SHT_MIPS_DWARF &&
+           Type == ELF::SHT_PROGBITS;
----------------
arichardson wrote:
> Should this be restricted to `Section->getName().startsWith (".debug")`?
Good point. I'll fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107707/new/

https://reviews.llvm.org/D107707



More information about the llvm-commits mailing list