[PATCH] D107707: [MC][ELF] Do not error on parsing .debug_* section directive for MIPS

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 8 09:55:07 PDT 2021


MaskRay added a comment.

> MIPS .debug_* sections should have SHT_MIPS_DWARF section type to distinguish among sections contain DWARF and ECOFF debug formats

If SHT_PROGBITS is a valid value, now what's the value keeping using SHT_MIPS_DWARF?

I know the ELF spirit is preferring section types to section names, but the reality with at least the 32-bit DWARF format is that architectures should just stick with SHT_PROGBITS.

That said, the patch LG.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107707/new/

https://reviews.llvm.org/D107707



More information about the llvm-commits mailing list