[PATCH] D107557: [OptTable] Refine how `printHelp` treats empty help texts

Fri Aug 6 09:10:18 PDT 2021

amccarth added a comment.

In D107557#2929544 <https://reviews.llvm.org/D107557#2929544>, @mstorsjo wrote:

> Hmm, that's a good question. Most of the options that are listed aren't even hooked up in llvm-cvtres (and the tool it impersonates, MS cvtres.exe, also just lists the options by name without any help text in its help printing).
>
> I guess we could add a help text for the options that we have implemented at least, and then omit the other ones. Or do @thakis or @amccarth have a strong opinion on it?

I don't have a strong opinion either way.  If a tool accepts an option, I'd prefer to see it listed.  If these options don't have help text because the tool is ignoring the option (but allowing it for compatibility), then I'd suggest we add some help text that says something to that effect, like "not implemented."

With `clang-cl /?`, I see `/Og` as "no effect".  There are also a few described as "Deprecated, <original purpose>".

@thakis may have stronger opinions on this than I do.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107557/new/

https://reviews.llvm.org/D107557