[PATCH] D107557: [OptTable] Refine how `printHelp` treats empty help texts

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 5 13:14:35 PDT 2021


mstorsjo added a subscriber: amccarth.
mstorsjo added a comment.

In D107557#2928167 <https://reviews.llvm.org/D107557#2928167>, @awarzynski wrote:

> With this change,  llvm/test/tools/llvm-cvtres/help.tes <https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/llvm-cvtres/help.test> is failing. That's because the help text in `llvm-cvtres` relies on the old behavior. The corresponding *.td file is tiny and perhaps @thakis or @mstorsjo  could suggest how to update it?

Hmm, that's a good question. Most of the options that are listed aren't even hooked up in llvm-cvtres (and the tool it impersonates, MS cvtres.exe, also just lists the options by name without any help text in its help printing).

I guess we could add a help text for the options that we have implemented at least, and then omit the other ones. Or do @thakis or @amccarth have a strong opinion on it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107557/new/

https://reviews.llvm.org/D107557



More information about the llvm-commits mailing list