[PATCH] D106139: [DAGCombine] Combine srX of add that intends to get the carry as uaddo

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 6 02:14:22 PDT 2021


dmgreen added a comment.

> We clearly do create intrinsics in some cases like:
> https://github.com/llvm/llvm-project/blob/0f4b41e038537ab2ab6fa2aa048e55c28a03ab68/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp#L1127

Yeah. The saturate instrinsics I consider differently because they don't produce two results. That at least keeps them simpler. That also allows vectorization (which is something that might not be needed in the future if the vectorizer learns to fold vector patterns) but at the moment is pretty important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106139/new/

https://reviews.llvm.org/D106139



More information about the llvm-commits mailing list