[PATCH] D107588: [AArch64][GlobalISel] Widen G_PTRTOINT before clamping + test legalization

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 5 16:06:29 PDT 2021


aemerson added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/legalize-ptrtoint.mir:27
+    ; CHECK: %ptr:_(p0) = COPY $x0
+    ; CHECK: %int:_(s32) = G_PTRTOINT %ptr(p0)
+    ; CHECK: $w0 = COPY %int(s32)
----------------
paquette wrote:
> aemerson wrote:
> > I expected these to change?
> The existing legality behaviour says it's okay:
> 
> `.legalForCartesianProduct({s1, s8, s16, s32, s64}, {p0})`
> 
> Should we just drop everything except for s64 entirely?
Yes I think so.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107588/new/

https://reviews.llvm.org/D107588



More information about the llvm-commits mailing list