[PATCH] D107569: [ORC] Emit i386 indirections for 32-bit processes on x86_64 hosts

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/Orc/IndirectionUtils.cpp:151
     case Triple::x86_64: {
+#if defined(LLVM_BUILD_32_BITS)
+      typedef orc::LocalJITCompileCallbackManager<orc::OrcI386> CCMgrT;
----------------
mgorny wrote:
> As I said on the bug, we normally don't use `LLVM_BUILD_32_BITS`. I think this is somewhat ugly but how about just using `__i386__`?
Didn't tests it yet, but if it works that's fine for me. It would avoid the CMake change. What do you think @lhames?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107569/new/

https://reviews.llvm.org/D107569