[PATCH] D107569: [ORC] Emit i386 indirections for 32-bit processes on x86_64 hosts

Thu Aug 5 08:14:05 PDT 2021

sgraenitz added a comment.

I did debug the misbehavior in `LazyCallThroughManager` specifically and verified that this change fixes the issue. I assume that the approach can/should be used in `IndirectStubsManager` and `JITCompileCallbackManager` as well, but these cases don't seem to have test coverage right now.

Note that this may not be sufficient to fix https://llvm.org/PR51292. There seems to be another issue with i386 call-through stubs that causes a subsequent segfault.

================
Comment at: llvm/lib/ExecutionEngine/Orc/IndirectionUtils.cpp:226
+#endif
+    }
 }
----------------
TODO: clang-format proposed this new indentation, but it doesn't look correct

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107569/new/

https://reviews.llvm.org/D107569