[PATCH] D107414: [Bazel] Add support for lld

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: utils/bazel/llvm-project-overlay/lld/BUILD.bazel:147
+        "//llvm:TransformUtils",
+        "//llvm:WindowsManifest",
+    ],
----------------
GMNGeoffrey wrote:
> MaskRay wrote:
> > In CMake, with `LLVM_ENABLE_LIBXML2` this dependency is essentially a no-op. Can Bazel allow optional builds?
> I don't totally understand the question. What do you mean by optional builds? There's configurability based on select
You said "Since the lld target itself requires libxml2 (through WindowsManifest) it's currently disabled on Buildkite and marked manual, but all the libraries build."

I think it'd be good to drop `tags = ["manual"]`. In CMake, `WindowsManifest` is built regardless of availability of libxml2.
When libxml2 is disabled, `WindowsManifest` is a stub. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107414/new/

https://reviews.llvm.org/D107414