[PATCH] D107414: [Bazel] Add support for lld
Geoffrey Martin-Noble via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 4 17:37:38 PDT 2021
GMNGeoffrey added inline comments.
================
Comment at: utils/bazel/llvm-project-overlay/lld/BUILD.bazel:239
+cc_library(
+ name = "MachO2",
+ srcs = glob(["MachO/**/*.cpp"]),
----------------
GMNGeoffrey wrote:
> MaskRay wrote:
> > Just `MachO`
> >
> > The special name can go to the old port which will go away soon.
> This matches the name in the CMake file (as do all the library names). I'd prefer not to diverge. Having these match makes it much easier to compare the Bazel and CMake rules. I'm happy to update this once the CMake name changes.
https://reviews.llvm.org/D107516 touche :-P
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107414/new/
https://reviews.llvm.org/D107414
More information about the llvm-commits
mailing list