[PATCH] D107388: Work around non-existence of ElfW(type) macro on FreeBSD

[Dimitry Andric via Phabricator via llvm-commits]

dim added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformLinux.c:23
+ * FreeBSD's elf.h and link.h headers do not define the ElfW(type) macro yet.
+ * If this is added to all supported FreeBSD versions in the future, this
+ * compatibility macro can be removed.
----------------
MaskRay wrote:
> (I expected an exact version, instead of a vague "If this is added to all supported FreeBSD versions in the future")
> 
> Without the comment, a reader may remember to clean up this as well.
Well, predictions are hard, especially about the future. :)

That said, if we add this macro to FreeBSD 14.0-CURRENT, it can be merged back to the existing stable branches, which are currently:
* 11.4-STABLE (but this expires in 2 months so there isn't going be a 11.5-RELEASE)
* 12.3-STABLE, which will likely result in 12.3-RELEASE at some point, but the date is not yet determined
* 13.1-STABLE, which will likely result in 13.1-RELEASE at some point, but the date is not yet determined

This type of addition is usually not added to existing releases, which typically only provide security fixes, and bug fixes that affect a large number of users.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107388/new/

https://reviews.llvm.org/D107388