[PATCH] D107388: Work around non-existence of ElfW(type) macro on FreeBSD

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 11:28:18 PDT 2021


MaskRay added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformLinux.c:23
+ * FreeBSD's elf.h and link.h headers do not define the ElfW(type) macro yet.
+ * If this is added to all supported FreeBSD versions in the future, this
+ * compatibility macro can be removed.
----------------
(I expected an exact version, instead of a vague "If this is added to all supported FreeBSD versions in the future")

Without the comment, a reader may remember to clean up this as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107388/new/

https://reviews.llvm.org/D107388



More information about the llvm-commits mailing list