[PATCH] D107363: [ARM][atomicrmw] Fix CMP_SWAP_32 expand assert

Wed Aug 4 06:20:27 PDT 2021

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks

================
Comment at: llvm/test/CodeGen/ARM/cmpxchg.mir:1
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
 # RUN: llc -o - %s -mtriple=armv7-unknown-linux-gnu -verify-machineinstrs -run-pass=arm-pseudo | FileCheck %s
----------------
tmatheson wrote:
> dmgreen wrote:
> > This needs to be rerun, to generate the check lines. It is also probably best if both the llc run lines have FileCheck's to check the output, even if they might be different.
> I'm not convinced it needs the extra FileCheck noise, when all we really want to check is that it doesn't crash.
It makes them easier to maintain, and the extra check lines are useful to make sure it looks OK.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107363/new/

https://reviews.llvm.org/D107363