[PATCH] D107363: [ARM][atomicrmw] Fix CMP_SWAP_32 expand assert

Tomas Matheson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 09:40:39 PDT 2021


tmatheson added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/cmpxchg.mir:1
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
 # RUN: llc -o - %s -mtriple=armv7-unknown-linux-gnu -verify-machineinstrs -run-pass=arm-pseudo | FileCheck %s
----------------
dmgreen wrote:
> This needs to be rerun, to generate the check lines. It is also probably best if both the llc run lines have FileCheck's to check the output, even if they might be different.
I'm not convinced it needs the extra FileCheck noise, when all we really want to check is that it doesn't crash.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107363/new/

https://reviews.llvm.org/D107363



More information about the llvm-commits mailing list