[PATCH] D107405: [WebAssembly] Misc. cosmetic changes in EH (NFC)

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 21:01:58 PDT 2021


aheejin marked 2 inline comments as done.
aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp:229
+  Function *SaveSetjmpF = nullptr;        // saveSetjmp() (Emscripten)
+  Function *TestSetjmpF = nullptr;        // testSetjmp() (Emscripten)
 
----------------
tlively wrote:
> Do the parentheses describe what part of the system is responsible for supplying the function/variable?
Yes. 'Emscripten' means Emscripten library. Wanted to write "library" too but that exceeds 80 cols and didn't want to make these inline comments to spill over.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107405/new/

https://reviews.llvm.org/D107405



More information about the llvm-commits mailing list