[PATCH] D107405: [WebAssembly] Misc. cosmetic changes in EH (NFC)

[Thomas Lively via Phabricator via llvm-commits]

tlively accepted this revision.
tlively added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:68
+// 'catch' instruction. This returns a single pointer, which is the case for C++
+// exceptions. support. The immediate argument is an index to for a tag, which
+// is 0 for C++ exceptions.
----------------



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp:229
+  Function *SaveSetjmpF = nullptr;        // saveSetjmp() (Emscripten)
+  Function *TestSetjmpF = nullptr;        // testSetjmp() (Emscripten)
 
----------------
Do the parentheses describe what part of the system is responsible for supplying the function/variable?


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp:839
+      // handled in somewhere up the call chain where setjmp is. __THREW__'s
+      // value is 0 when nothing happened, 1 when an exception is thrown, other
+      // values when longjmp is thrown.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107405/new/

https://reviews.llvm.org/D107405