[PATCH] D107406: [DAGCombiner][TLI] SimplifySetCC(): recanonicalize `(X&1) != 0` (PR51312)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 16:49:50 PDT 2021


lebedev.ri abandoned this revision.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

Actually, let's not.



================
Comment at: llvm/test/CodeGen/X86/parity-vec.ll:66
 ; CHECK-NEXT:    testb $1, %al
 ; CHECK-NEXT:    sete %al
 ; CHECK-NEXT:    retq
----------------
craig.topper wrote:
> Is this a different issue?
It's similar in a way, here we need `(x&1)^1` or `x^1`.
But allowing `Cond == ISD::SETNE` results in a swamp of regressions.,
with a few wins. Perhaps that highlights that the approach is wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107406/new/

https://reviews.llvm.org/D107406



More information about the llvm-commits mailing list