[PATCH] D107048: [dwarf][bugfix] Recompute the size of block before getting it's BestForm

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added a comment.

In D107048#2921510 <https://reviews.llvm.org/D107048#2921510>, @jhenderson wrote:

> In D107048#2921507 <https://reviews.llvm.org/D107048#2921507>, @djtodoro wrote:
>
>> In D107048#2921504 <https://reviews.llvm.org/D107048#2921504>, @djtodoro wrote:
>>
>>> Can we make the test by using YAML (by hard-coding the DWARF)?
>>
>> An example of DWARF YAML test is `llvm/test/tools/llvm-dwarfdump/X86/stats-scope-bytes-covered.yaml`.
>
> @Higuoxing may be able to assist with this, if he's around - he did a fair bit of the yaml2obj DWARF support.

IMHO, using unittest is more appropriate. `CodeGen` is not employed in `yaml2obj`, hence this code path cannot be tested using YAML.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107048/new/

https://reviews.llvm.org/D107048