[PATCH] D107048: [dwarf][bugfix] Recompute the size of block before getting it's BestForm

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D107048#2921606 <https://reviews.llvm.org/D107048#2921606>, @djtodoro wrote:

> In D107048#2921597 <https://reviews.llvm.org/D107048#2921597>, @skan wrote:
>
>> In D107048#2915591 <https://reviews.llvm.org/D107048#2915591>, @MaskRay wrote:
>>
>>> You may use cvise or creduce to reduce the original source file.
>>
>> yeah, I am trying to use creduce and waiting for the result.
>
> I don't expect any improvement from using the creduce here since the metadata part is too long. Something like the [0] may help, but it supports reducing of DILocations only at the moment. Also, there is a WIP (inside SONY) for extending the llvm-reduce to support reducing of DI Metadata part (since it doesn't touch it now).
>
> [0] https://github.com/djolertrk/llvm-metadataburn

Yeah, @maskray at least was talking about reducing the original source, not IR - hopefully that's what @skan is doing. It makes for rather more legible/justifiable test cases to reduce the original source to get real-world (rather than quirky reduced) IR (though if we ever got a compact enough syntax, I'd be happy with more further reduced IR or hand-written cases, but as it is now it's so verbose that the hand-modifying to make them more dense usually isn't worth the time and for anything sufficiently complex I worry that machine reduced would make such unrealistic examples as to be unhelpful)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107048/new/

https://reviews.llvm.org/D107048