[PATCH] D107362: GlobalISel: Fix CombinerHelper::matchEqualDefs() for unmerge

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Is this a bug fix or just a missed optimization? Surely matchEqualDefs is not **required** to return true when two defs have the same value?



================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:2736
     // have come from the same COPY.
     return I1->isIdenticalTo(*I2);
   }
----------------
Maybe your new code ought to go here? And maybe it should apply to any instruction with multiple return registers, not just unmerge?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107362/new/

https://reviews.llvm.org/D107362