[PATCH] D107041: [Flang] Ported test_symbols to Python

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added inline comments.


================
Comment at: flang/test/Semantics/test_symbols.py:47
+# Compares the input with the output
+for line in unified_diff(diff1, diff3, n=999999, fromfile="1.90", tofile="3.f90"):
+    diff_check += line
----------------
kiranchandramohan wrote:
> Would it be better to rename 1.f90 to source.f90 and 3.f90 to compiled.f90?
> Otherwise, there can be the question, what happened to 2.f90?
Also, in the original test script it was `$temp/1.90`: https://github.com/llvm/llvm-project/blob/main/flang/test/Semantics/test_symbols.sh#L12-L14. IIUC, `$temp` is a directory unique to the corresponding test. Are you preserving this here? Otherwise tests will start failing in weird way when run in parallel.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107041/new/

https://reviews.llvm.org/D107041