[PATCH] D107041: [Flang] Ported test_symbols to Python

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

A few minor comments.



================
Comment at: flang/test/Semantics/common.py:1
+#!/usr/bin/python3
+
----------------
Nit: Is this script directly executed? If not do we need this here?


================
Comment at: flang/test/Semantics/common.py:36
+    if len(args) < 3:
+        print(f"Usage: {args[0]} <fortran-source> <f18-command>")
+        sys.exit(1)
----------------
Nit: you can rename f18-command as flang-command.


================
Comment at: flang/test/Semantics/test_symbols.py:47
+# Compares the input with the output
+for line in unified_diff(diff1, diff3, n=999999, fromfile="1.90", tofile="3.f90"):
+    diff_check += line
----------------
Would it be better to rename 1.f90 to source.f90 and 3.f90 to compiled.f90?
Otherwise, there can be the question, what happened to 2.f90?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107041/new/

https://reviews.llvm.org/D107041