[PATCH] D107314: [MC][CodeGen] Emit constant pools earlier
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 2 23:00:46 PDT 2021
MaskRay added inline comments.
================
Comment at: llvm/include/llvm/MC/MCStreamer.h:128
+
+ virtual void emitConstantPools();
};
----------------
I may place this above, grouping with a few other `emit*`.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1818
+ if (auto *TS = OutStreamer->getTargetStreamer())
+ TS->emitConstantPools();
----------------
Perhaps a comment that this needs to be before debug information.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107314/new/
https://reviews.llvm.org/D107314
More information about the llvm-commits
mailing list