[PATCH] D107314: [MC][CodeGen] Emit constant pools earlier

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

LG. Calling `MCStreamer::endSection` early may look weird, but otherwise we need to call it elsewhere. Keeping `MCStreamer::endSection` in DwarfDebug.cpp as is looks fine for now.



================
Comment at: llvm/test/MC/ARM/arange-ldr.ll:1
+; RUN: llc %s -o - | FileCheck %s
+
----------------
How about test/DebugInfo/ARM/

Add a file-level comment about the purpose of the test


================
Comment at: llvm/test/MC/ARM/arange-ldr.ll:6
+
+; CHECK: ldr
+; CHECK: 83040
----------------
```
CHECK:       ldr r7, .Ltmp[[#TMP:]]

CHECK:      .tmp[[#TMP]]:
CHECK-NEXT: .long  83040
```


================
Comment at: llvm/test/MC/ARM/arange-ldr.ll:8
+; CHECK: 83040
+
+define dso_local void @a() local_unnamed_addr !dbg !4 {
----------------
Have some basic checking for .debug_aranges



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107314/new/

https://reviews.llvm.org/D107314