[PATCH] D105591: [AArch64][SelectionDAG] Support passing/returning scalable vectors with unusual types.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 2 14:49:57 PDT 2021
efriedma added a comment.
In D105591#2920910 <https://reviews.llvm.org/D105591#2920910>, @efriedma wrote:
> In D105591#2920820 <https://reviews.llvm.org/D105591#2920820>, @sdesmalen wrote:
>
>> The patch is a bit tricky to follow because it has many changing parts, so it's not always clear that all the parts are covered by the tests, but I trust you've made all these changes for a reason.
>
> I'll experiment a bit to see if there's some way to separate out the legalization changes; the llvm.experimental.vector.extract tricks I figured out for D106028 <https://reviews.llvm.org/D106028> might be usable for that. The rest is sort of tied together.
Oh, right... if I try that, I get into issues with the extract/insert themselves, which end up needing more code to make them work.
I think it's reasonable to commit this as a single unit, even if it might theoretically be possible to split it more.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105591/new/
https://reviews.llvm.org/D105591
More information about the llvm-commits
mailing list