[PATCH] D105591: [AArch64][SelectionDAG] Support passing/returning scalable vectors with unusual types.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 2 14:27:06 PDT 2021


efriedma added a comment.

In D105591#2920820 <https://reviews.llvm.org/D105591#2920820>, @sdesmalen wrote:

> The patch is a bit tricky to follow because it has many changing parts, so it's not always clear that all the parts are covered by the tests, but I trust you've made all these changes for a reason.

I'll experiment a bit to see if there's some way to separate out the legalization changes; the llvm.experimental.vector.extract tricks I figured out for D106028 <https://reviews.llvm.org/D106028> might be usable for that.  The rest is sort of tied together.

> Does D106028 <https://reviews.llvm.org/D106028> depend on this patch? (I'm thinking mostly about the widening)

There isn't an explicit dependency.  The SplitVecRes_INSERT_SUBVECTOR here is a less general version of the one in D106028 <https://reviews.llvm.org/D106028>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105591/new/

https://reviews.llvm.org/D105591



More information about the llvm-commits mailing list