[PATCH] D107196: [AArch64InstPrinter] Change printAddSubImm to only add imm value comment when shifted
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 31 14:11:57 PDT 2021
MaskRay added a comment.
Currently `--print-imm-hex` can change `; =1191936` to the hexadecimal form.
I do feel unconditionally hex comments are better and think an option for decimal comment may unlikely be needed.
So LGTM as a follow-up.
================
Comment at: llvm/test/tools/llvm-objdump/ELF/AArch64/disassemble-align.s:6
# CHECK:0000000000000000 <$x.0>:
-# CHECK-NEXT: 0: 62 10 00 91 |add|x2, x3, #4 // =4
+# CHECK-NEXT: 0: 62 10 00 91 |add|x2, x3, #4
# CHECK-NEXT: 4: 1f 20 03 d5 |nop
----------------
Perhaps append `{{$}}` to ensure there is no comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107196/new/
https://reviews.llvm.org/D107196
More information about the llvm-commits
mailing list