[PATCH] D107196: [AArch64InstPrinter] Change printAddSubImm to only add imm value comment when shifted
Jason Molenda via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 31 12:58:33 PDT 2021
jasonmolenda added a comment.
An interesting side question as long as we're talking about this printer,
add x9, x0, #291, lsl #12 ; =1191936
once we have a shifted imm value, adding the value in base10 to the comment stream is maybe not the best choice. This could be printed as,
add x9, x0, #291, lsl #12 ; =0x123000
Anyone have an opinion one way or the other?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107196/new/
https://reviews.llvm.org/D107196
More information about the llvm-commits
mailing list