[PATCH] D106872: [InstCombine] Remove nnan requirement for transformation to fabs from select

[Krishna Kariya via Phabricator via llvm-commits]

Krishnakariya updated this revision to Diff 363286.
Krishnakariya added a comment.

Added new tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106872/new/

https://reviews.llvm.org/D106872

Files:
  llvm/test/Transforms/InstCombine/fabs.ll


Index: llvm/test/Transforms/InstCombine/fabs.ll
===================================================================
--- llvm/test/Transforms/InstCombine/fabs.ll
+++ llvm/test/Transforms/InstCombine/fabs.ll
@@ -343,6 +343,19 @@
 
 ; X > 0.0 ? X : (0.0 - X) --> fabs(X)
 
+define fp128 @select_fcmp_ogt_zero(fp128 %x) {
+; CHECK-LABEL: @select_fcmp_ogt_zero(
+; CHECK-NEXT:    [[GTZERO:%.*]] = fcmp ogt fp128 [[X:%.*]], 0xL00000000000000000000000000000000
+; CHECK-NEXT:    [[NEGX:%.*]] = fsub fp128 0xL00000000000000000000000000000000, [[X]]
+; CHECK-NEXT:    [[FABS:%.*]] = select i1 [[GTZERO]], fp128 [[X]], fp128 [[NEGX]]
+; CHECK-NEXT:    ret fp128 [[FABS]]
+;
+  %gtzero = fcmp ogt fp128 %x, zeroinitializer
+  %negx = fsub fp128 zeroinitializer, %x
+  %fabs = select i1 %gtzero, fp128 %x, fp128 %negx
+  ret fp128 %fabs
+}
+
 define fp128 @select_fcmp_nnan_ogt_zero(fp128 %x) {
 ; CHECK-LABEL: @select_fcmp_nnan_ogt_zero(
 ; CHECK-NEXT:    [[TMP1:%.*]] = call fp128 @llvm.fabs.f128(fp128 [[X:%.*]])
@@ -419,6 +432,19 @@
 
 ; X < 0.0 ? -X : X --> fabs(X)
 
+define double @select_fcmp_olt_zero_unary_fneg(double %x) {
+; CHECK-LABEL: @select_fcmp_olt_zero_unary_fneg(
+; CHECK-NEXT:    [[LTZERO:%.*]] = fcmp olt double [[X:%.*]], 0.000000e+00
+; CHECK-NEXT:    [[NEGX:%.*]] = fneg double [[X]]
+; CHECK-NEXT:    [[FABS:%.*]] = select nsz i1 [[LTZERO]], double [[NEGX]], double [[X]]
+; CHECK-NEXT:    ret double [[FABS]]
+;
+  %ltzero = fcmp olt double %x, 0.0
+  %negx = fneg double %x
+  %fabs = select nsz i1 %ltzero, double %negx, double %x
+  ret double %fabs
+}
+
 define double @select_fcmp_nnan_nsz_olt_zero(double %x) {
 ; CHECK-LABEL: @select_fcmp_nnan_nsz_olt_zero(
 ; CHECK-NEXT:    [[LTZERO:%.*]] = fcmp olt double [[X:%.*]], 0.000000e+00
@@ -695,6 +721,19 @@
 
 ; X > 0.0 ? X : (0.0 - X) --> fabs(X)
 
+define <2 x float> @select_fcmp_ogt_zero_unary_fneg(<2 x float> %x) {
+; CHECK-LABEL: @select_fcmp_ogt_zero_unary_fneg(
+; CHECK-NEXT:    [[GTZERO:%.*]] = fcmp ogt <2 x float> [[X:%.*]], zeroinitializer
+; CHECK-NEXT:    [[NEGX:%.*]] = fneg <2 x float> [[X]]
+; CHECK-NEXT:    [[FABS:%.*]] = select nsz <2 x i1> [[GTZERO]], <2 x float> [[X]], <2 x float> [[NEGX]]
+; CHECK-NEXT:    ret <2 x float> [[FABS]]
+;
+  %gtzero = fcmp ogt <2 x float> %x, zeroinitializer
+  %negx = fneg <2 x float> %x
+  %fabs = select nsz <2 x i1> %gtzero, <2 x float> %x, <2 x float> %negx
+  ret <2 x float> %fabs
+}
+
 define <2 x float> @select_fcmp_nnan_nsz_ogt_zero(<2 x float> %x) {
 ; CHECK-LABEL: @select_fcmp_nnan_nsz_ogt_zero(
 ; CHECK-NEXT:    [[GTZERO:%.*]] = fcmp ogt <2 x float> [[X:%.*]], zeroinitializer


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106872.363286.patch
Type: text/x-patch
Size: 2620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210731/7ae92137/attachment.bin>