[PATCH] D106872: [InstCombine] Remove nnan requirement for transformation to fabs from select

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

This was discussed as a follow-up for D101727 <https://reviews.llvm.org/D101727>.
I originally added the `nnan` check to these transforms to be extra safe (and so watch for potential fallout on out-of-tree targets), but it's not necessary in the default LLVM FP environment to preserve exact bits of a `nnan`.
Ie, the sign of `nnan` will always be cleared by fabs, but not in the original code.

I'm not sure what the tests are showing. I would expect there to be 4 tests corresponding to each code change with no `nnan` that are now getting transformed?
Please pre-commit all tests with baseline CHECKs as a preliminary patch (no review is needed for that). 
If you do not have commit access, now is a good time to request it. :)
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106872/new/

https://reviews.llvm.org/D106872