[PATCH] D107159: [DA] control compile-time spent by MIV tests

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 30 15:13:56 PDT 2021


Meinersbur added a comment.

In D107159#2917586 <https://reviews.llvm.org/D107159#2917586>, @bmahjour wrote:

> In D107159#2917530 <https://reviews.llvm.org/D107159#2917530>, @Meinersbur wrote:
>
>> Is it feasible tp add a test-case that reaches the threshold? If a loop depth of 12 takes a minute, would a test with depth 10 still be acceptable to run as part of the regression tests?
>
> Not sure if it would be good to add a potentially long-running test (like a 10-level deep nest) to check-llvm. I tried this on a pretty powerful server...smaller systems or those under heavy load will likely take longer. However if you are interested in making sure that the DA results are still sensible when the threshold is reached, I could have a smaller, say 3-level loop nest and analyze it with `da-miv-max-level-threshold=2`. Would that be good?

Yes, that would be great! SCEV uses this approach as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107159/new/

https://reviews.llvm.org/D107159



More information about the llvm-commits mailing list