[PATCH] D107048: [dwarf][bugfix] Recompute the size of block before getting it's BestForm
Xiang Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 29 22:23:39 PDT 2021
xiangzhangllvm added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:408
void DwarfUnit::addBlock(DIE &Die, dwarf::Attribute Attribute,
DIEBlock *Block) {
----------------
I +1 first.
This addBlock is simplify for line 401, and the Block->BestForm decided by Size, I agree with this change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107048/new/
https://reviews.llvm.org/D107048
More information about the llvm-commits
mailing list