[PATCH] D107048: [dwarf][bugfix] Recompute the size of block before getting it's BestForm

[Kan Shengchen via Phabricator via llvm-commits]

skan added a comment.

In D107048#2915537 <https://reviews.llvm.org/D107048#2915537>, @xiangzhangllvm wrote:

>> The size of the block need to be recomputed before determing the BestForm ....  the test is too big
>
> So if the BestForm is not right, what bug it will cause, can you simplify the test ?

The issue is that if we get the BestForm before recomputing its size, then BestForm will not be accurate.

To be honest, I am not a expert in dwarf format and don't know how to trigger the bug with a smaller LIT test.  However, this bugfix is direct and simple,  I think we can fix it even w/o test.

The unnit tests for class  `DwarfUnit` are missing in LLVM, so it takes much more work to test this code by unit test and I think someone who are more familiar with dwarf code could add the unit tests in the future.

@dblaikie @xiangzhangllvm  How do you think about it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107048/new/

https://reviews.llvm.org/D107048