[PATCH] D106421: Encode address offsets of basic blocks relative to the end of the previous basic blocks.

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added a comment.

Thanks for the review @tmsriram and @jhenderson.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6762
         W.printHex("Size", BBE.Size);
+        FunctionRelativeAddress += BBE.Size;
         W.printBoolean("HasReturn", BBE.HasReturn);
----------------
tmsriram wrote:
> Just making sure, is it possible that there could be some padding between basic blocks which might not get accounted for in size calculations?  I guess this is being done after the assembler has done its work so it should be fine?
Yes. The padding you are mentioning is `BBE.Offset`. This is the offset from the end of a block to the beginning of the next. So it will be accounted for as well (at line 6759).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106421/new/

https://reviews.llvm.org/D106421