[PATCH] D106421: Encode address offsets of basic blocks relative to the end of the previous basic blocks.

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 26 10:02:25 PDT 2021


tmsriram accepted this revision.
tmsriram added a comment.

LGTM



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6762
         W.printHex("Size", BBE.Size);
+        FunctionRelativeAddress += BBE.Size;
         W.printBoolean("HasReturn", BBE.HasReturn);
----------------
Just making sure, is it possible that there could be some padding between basic blocks which might not get accounted for in size calculations?  I guess this is being done after the assembler has done its work so it should be fine?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106421/new/

https://reviews.llvm.org/D106421



More information about the llvm-commits mailing list