[PATCH] D107097: [llvm-profgen] An option to ignore parsing MMap events

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

In D107097#2914876 <https://reviews.llvm.org/D107097#2914876>, @wenlei wrote:

> In D107097#2914487 <https://reviews.llvm.org/D107097#2914487>, @hoy wrote:
>
>> Can the mmap events be treated as optional, so when they present we parse them otherwise just move forward to other events?
>
> +1. I was thinking about the same..
>
> We can start with assuming all binaries are loaded at preferred based,

This is my two cents.

> then on mmap event we update the base for binary,

I was thinking about warning or erroring for this. Erroring is probably two strong. An interior mmap event without a corresponding leading event likely means the profiling system doesn't work consistently, i.e., it sometimes grabs mmap event but sometimes not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107097/new/

https://reviews.llvm.org/D107097