[PATCH] D107097: [llvm-profgen] An option to ignore parsing MMap events

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 15:01:36 PDT 2021


wenlei added a comment.

In D107097#2914487 <https://reviews.llvm.org/D107097#2914487>, @hoy wrote:

> Can the mmap events be treated as optional, so when they present we parse them otherwise just move forward to other events?

+1. I was thinking about the same..

We can start with assuming all binaries are loaded at preferred based, then on mmap event we update the base for binary, on other event, we process them using the current base (would be preferred base if no relevant mmap is seen before), and warn if there's no mmap before that event?

The above would be the default behavior without any switch. Is that what we're trying to do? If we want we could add a switch to always require mmap and error out if we don't find mmap for a binary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107097/new/

https://reviews.llvm.org/D107097



More information about the llvm-commits mailing list