[PATCH] D107088: [ARC] Add additional mov immediate instruction formats with a fix for u6 decoding
Thomas Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 29 12:13:04 PDT 2021
thomasjohns added inline comments.
================
Comment at: llvm/test/MC/Disassembler/ARC/alu.txt:195
+# CHECK: rsub.eq %r0, %r0, 31
+0xce 0x20 0xe1 0x07
----------------
marksl wrote:
> You should probably check something other than R0 to verify the field is defined correctly. R0 will just encode zeros which may not show up an error.
Okay thanks, that's a good idea. I will update the patch with more varied register numbers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107088/new/
https://reviews.llvm.org/D107088
More information about the llvm-commits
mailing list