[PATCH] D107062: [flang][nfc] Fix variable names in `FrontendOptions`

Peter Klausler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 12:00:11 PDT 2021


klausler accepted this revision.
klausler added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/include/flang/Frontend/FrontendOptions.h:253
+      : showHelp(false), showVersion(false), instrumentedParse(false),
+        needProvenanceRangeToCharBlockMappings(false) {}
 
----------------
It is confusing to have data member initialization mixed between the constructor and the data member declarations when all of initialization expressions are constants.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107062/new/

https://reviews.llvm.org/D107062



More information about the llvm-commits mailing list