[PATCH] D107062: [flang][nfc] Fix variable names in `FrontendOptions`
Andrzej Warzynski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 29 05:45:32 PDT 2021
awarzynski created this revision.
Herald added a reviewer: sscalpone.
awarzynski requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
As all member variables in `FrontendOptions` are public, we should be
naming them as `variable` rather than `variable_` [1]. This patch will
fix that.
Also, `FrontendOptions` is re-defined as a struct rather than a
class (all fields are meant to be public).
[1]
https://github.com/llvm/llvm-project/blob/main/flang/docs/C%2B%2Bstyle.md#naming
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D107062
Files:
flang/docs/FlangDriver.md
flang/include/flang/Frontend/CompilerInstance.h
flang/include/flang/Frontend/FrontendOptions.h
flang/lib/Frontend/CompilerInstance.cpp
flang/lib/Frontend/CompilerInvocation.cpp
flang/lib/Frontend/FrontendAction.cpp
flang/lib/Frontend/FrontendActions.cpp
flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp
flang/unittests/Frontend/FrontendActionTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107062.362733.patch
Type: text/x-patch
Size: 21386 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210729/e13da77e/attachment.bin>
More information about the llvm-commits
mailing list