[PATCH] D91053: [PowerPC] Lump the constants to save one addis for each constant access

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 20:04:43 PDT 2021


qiucf added a comment.

In D91053#2912191 <https://reviews.llvm.org/D91053#2912191>, @lkail wrote:

> A few months ago, steven shared his patch to us. For me, it should be an optimization of TOC layout, it looks odd to me to get it done at isel phase. I think we should figure out a new approach for this. What do you think @nemanjai @qiucf ?
>
> I tend to not pursue this patch and might have a new one to get TOC layout optimization done.

I think it's located at DAG because we lower such constant pools stuff there. If this can be target independent (as Eli commented in previous patch) in DAG, or put it after ISel (I guess you mean that?), it's fine to abandon that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91053/new/

https://reviews.llvm.org/D91053



More information about the llvm-commits mailing list