[PATCH] D91053: [PowerPC] Lump the constants to save one addis for each constant access

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 19:53:43 PDT 2021


lkail added a comment.

> I believe this still depends on https://reviews.llvm.org/D91050 which isn't really generating much support. If this is still dependent on that, can you please address the comments on the dependent patch? If it no longer depends on that patch, please commandeer that one as well and abandon it.

A few months ago, steven shared his patch to us. For me, it should be an optimization of TOC layout, it looks odd to me to get it done at isel phase. I think we should figure out a new approach for this. What do you think @nemanjai @qiucf ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91053/new/

https://reviews.llvm.org/D91053



More information about the llvm-commits mailing list