[PATCH] D106861: [CSSPGO] Migrate and refactor the decoder of Pseudo Probe

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 19:15:52 PDT 2021


wlei added inline comments.


================
Comment at: llvm/lib/MC/MCPseudoProbe.cpp:339
+#ifndef NDEBUG
+  SectionName = "pseudo_probe_desc";
+#endif
----------------
Same here


================
Comment at: llvm/lib/MC/MCPseudoProbe.cpp:406
+#ifndef NDEBUG
+  SectionName = "pseudo_probe";
+#endif
----------------
As we use return type to handle error, `SectionName` here is no longer used, right? If so, this can be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106861/new/

https://reviews.llvm.org/D106861



More information about the llvm-commits mailing list