[PATCH] D106861: [CSSPGO] Migrate and refactor the decoder of Pseudo Probe
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 28 19:00:36 PDT 2021
hoy added a comment.
P.S. lgtm in general. I have done an around of code review internally before sending out the diff.
================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:184
+ exitWithError("Pseudo Probe decoder fail in " +
+ ProbeDecoder.getSectionName());
} else if (SectionName == ".pseudo_probe") {
----------------
Nit: can just use .pseudo_probe_desc instead of `ProbeDecoder.getSectionName()`. Similarly below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106861/new/
https://reviews.llvm.org/D106861
More information about the llvm-commits
mailing list